Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web3 Signer integration updates for merge #10053

Closed
2 of 3 tasks
james-prysm opened this issue Jan 5, 2022 · 1 comment 路 Fixed by #10964
Closed
2 of 3 tasks

Web3 Signer integration updates for merge #10053

james-prysm opened this issue Jan 5, 2022 · 1 comment 路 Fixed by #10964
Assignees
Labels
API Api related tasks Builder PR or issue that supports builder related work Merge PRs related to the great milestone the merge Web3Signer Web3Signer related tasks

Comments

@james-prysm
Copy link
Contributor

james-prysm commented Jan 5, 2022

馃拵 Issue

Background

This issue tracks changes for web3signer with regards to the merge

Description

we will need to update the types to include the block v3 type
also the block body for the request will need to change; reference to the following issue below.
Consensys/web3signer#437
Consensys/web3signer#459
Consensys/web3signer#606

Bellatrix changes Consensys/teku#5354

For Bellatrix fork, send block_header instead of block for external signer block signing request (BLOCK_V2). block_header contains body_root instead of complete beacon block body which significantly reduces the traffic between Teku and external signer for block signing request.

Either block_header or block can be used to calculate signing root by the external signer. For backward compatibility with PHASE0 and ALTAIR forks, only block is sent; for Bellatrix and later forks, only block_header is sent.

Prysm uses BLOCK_V3 Instead

Tasks

  • manage bellatrix blocks ( blockv3/ handling block body to block header in payload)
  • handling blinded blocks
  • validator registration signing ( MEV/Builder)
@james-prysm james-prysm added API Api related tasks Merge PRs related to the great milestone the merge Web3Signer Web3Signer related tasks labels Jan 5, 2022
@james-prysm james-prysm self-assigned this Jan 5, 2022
@ghost
Copy link

ghost commented Jan 18, 2022

good work man, im new but i love this

@prysmaticlabs prysmaticlabs deleted a comment Feb 2, 2022
@james-prysm james-prysm added the Builder PR or issue that supports builder related work label Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Api related tasks Builder PR or issue that supports builder related work Merge PRs related to the great milestone the merge Web3Signer Web3Signer related tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant