-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flaky test //beacon-chain/p2p:go_default_test #10160
Comments
I'm interested in helping on this task. I just followed the Contributer guide and got a local environment to finish |
Reading the test in TestVerifyConnectivity, some initial thoughts are:
The next steps I can attempt are to gather data to narrow down what is contributing to the failures. For example, choosing a destination that expressly accepts test requests, increasing delay between test run iterations, increasing dial-timeout, or try UDP port 53 (dns). |
Hey @patterns , thanks for taking a look at this ! Just assigned you the issue. It seems you already have made good progress on this :) , looking forward to the improvements to these tests. |
Very appreciated, thanks! I think I have the
I need to confirm whether is correct. At the same time, I'll try to understand the second failing test (Discovery-Attempts one). |
Hey @patterns , That is correct, the |
馃悶 Bug Report
Description
p2p tests are extremely flaky. These tests typically pass around one in ten runs.
I ran this test with
--test_strategy=exclusive --runs_per_test=500
overnight and the result is as follows:Has this worked before in a previous version?
This has been an issue for some time. It passes in CI as this package is rarely changed and a passing test is cached between CI requests.
馃敩 Minimal Reproduction
bazel or go test
馃敟 Error
馃實 Your Environment
Operating System:
What version of Prysm are you running? (Which release)
Latest develop commit
Anything else relevant (validator index / public key)?
The text was updated successfully, but these errors were encountered: