Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement per valdiator reward API #11581

Closed
terencechain opened this issue Oct 26, 2022 · 3 comments
Closed

Implement per valdiator reward API #11581

terencechain opened this issue Oct 26, 2022 · 3 comments
Labels
API Api related tasks UX cosmetic / user experience related

Comments

@terencechain
Copy link
Member

Some of these APIs that @michaelsproul proposed provide excellent visibility to validator performances, I think Prysm should consider them and even better promote them to be part of the beacon API standard

sigp/lighthouse#3661

@terencechain terencechain added API Api related tasks UX cosmetic / user experience related labels Oct 26, 2022
@potuz
Copy link
Contributor

potuz commented Oct 27, 2022

If these metrics can be exposed by the beacon monitor and the standard is agnostic to who is exporting these metrics then I think we should implement these in the monitor. I don't like the fact that we're computing validator metrics repeatedly now and would want to deprecate validator client metrics in favor of the beacon ones

@terencechain
Copy link
Member Author

If these metrics can be exposed by the beacon monitor and the standard is agnostic to who is exporting these metrics then I think we should implement these in the monitor. I don't like the fact that we're computing validator metrics repeatedly now and would want to deprecate validator client metrics in favor of the beacon ones

I agree that we should remove validator client metrics and promote beacon node side monitoring metrics

@potuz
Copy link
Contributor

potuz commented Nov 4, 2022

@sproul explained that I had a misconception of what this API is about. The beacon monitor will not be a place for these. The monitor could be the natural consumer of this endpoints in order to export tracking metrics. But the API and the endpoints themselves need to be in the beacon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Api related tasks UX cosmetic / user experience related
Projects
None yet
Development

No branches or pull requests

2 participants