Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong type in /eth/v1/config/deposit_contract endpoint #12949

Closed
pk910 opened this issue Sep 23, 2023 · 1 comment · Fixed by #12952
Closed

Wrong type in /eth/v1/config/deposit_contract endpoint #12949

pk910 opened this issue Sep 23, 2023 · 1 comment · Fixed by #12952
Labels
Bug Something isn't working

Comments

@pk910
Copy link

pk910 commented Sep 23, 2023

Describe the bug

Prysm nodes currently return the chain_id field in /eth/v1/config/deposit_contract as numeric value:

{
    "data": {
        "chain_id": 7011893058,
        "address": "0x6f22fFbC56eFF051aECF839396DD1eD9aD6BBA9D"
    }
}

According to the specs this should be a string ("7011893058").

Some downstream libraries (eg. attestantio/go-eth2-client) don't like that and fail on initialization because of that.

Has this worked before in a previous version?

probably there since ~2 weeks, the relevant code has been touched in #12872

🔬 Minimal Reproduction

call /eth/v1/config/deposit_contract api and check result

Error

No response

Platform(s)

No response

What version of Prysm are you running? (Which release)

No response

Anything else relevant (validator index / public key)?

No response

@saolyn
Copy link
Contributor

saolyn commented Sep 25, 2023

Thank you for bringing this to our attention

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants