Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Gossip Validations with Blob Inclusion Header Signature #13154

Closed
terencechain opened this issue Nov 1, 2023 · 2 comments
Closed

Optimize Gossip Validations with Blob Inclusion Header Signature #13154

terencechain opened this issue Nov 1, 2023 · 2 comments
Assignees
Labels
Deneb PRs or issues for the Deneb upgrade

Comments

@terencechain
Copy link
Member

With the introduction of blob inclusion proof and new format of blob sidecar, the process of gossip validations across blob sidecar(s) and beacon block has become more efficient. Specifically, we now only have to verify a single signature. This issue aims to track the work related to these optimizations.

@terencechain terencechain added the Deneb PRs or issues for the Deneb upgrade label Nov 1, 2023
@kasey
Copy link
Contributor

kasey commented Dec 7, 2023

groundwork for this was laid here #13245
and I believe it will be wired into gossip here #13294

Note that this will cache signature verification amongst the blobs, but to also share the cache with blocks, we need to add a verification.BlockVerifier and use that in place of block gossip validation code.

@kasey
Copy link
Contributor

kasey commented Jan 8, 2024

In gossip, we cache signature verification for blobs amongst the BlobSidecars, but not with the block verification. I think this state is OK for now and we can mark this for later improvement.

In batch sync, we trust the block batch processor to perform signature checks before calling the DA check and do a cheap comparison of the signature bytes.

So I think this is resolved for now and we can make a lower priority ticket for sharing the blob sig cache with blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deneb PRs or issues for the Deneb upgrade
Projects
Status: Done
Development

No branches or pull requests

2 participants