New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attester proposer slashing store #4315
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alidators # Conflicts: # slasher/flags/flags.go # slasher/main.go # slasher/service/data_update.go # slasher/service/service.go # slasher/service/service_test.go
Codecov Report
@@ Coverage Diff @@
## master #4315 +/- ##
=========================================
Coverage ? 13.42%
=========================================
Files ? 73
Lines ? 4813
Branches ? 0
=========================================
Hits ? 646
Misses ? 4066
Partials ? 101 |
…_proposer_slashing_store
…_proposer_slashing_store # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit. added comments
rauljordan
reviewed
Dec 20, 2019
…iclabs/prysm into attester_proposer_slashing_store
nisdas
reviewed
Jan 13, 2020
nisdas
previously approved these changes
Jan 13, 2020
nisdas
reviewed
Jan 13, 2020
nisdas
previously approved these changes
Jan 13, 2020
terencechain
requested changes
Jan 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
goimports
Co-Authored-By: terence tsao <terence@prysmaticlabs.com>
…iclabs/prysm into attester_proposer_slashing_store
@terencechain fixed imports |
terencechain
approved these changes
Jan 14, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* Merge branch 'master' of github.com:prysmaticlabs/prysm into update_validators # Conflicts: # slasher/flags/flags.go # slasher/main.go # slasher/service/data_update.go # slasher/service/service.go # slasher/service/service_test.go * proposal and attester store * day to status * comment change * one bucket * Merge branch 'master' of github.com:prysmaticlabs/prysm into attester_proposer_slashing_store # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit. added comments * comment * typo fix * raul review fix * raul review fix full * nishant feedback * test fix * fix tests and remove update gofmt goimports * remove blank line in imports * nishant fixes * comment and fir delete proposer slashings * avoid marshal twice * remove space * Update slasher/db/attester_slashings.go Co-Authored-By: terence tsao <terence@prysmaticlabs.com> * terence feedback Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com> Co-authored-by: terence tsao <terence@prysmaticlabs.com>
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* Merge branch 'master' of github.com:prysmaticlabs/prysm into update_validators # Conflicts: # slasher/flags/flags.go # slasher/main.go # slasher/service/data_update.go # slasher/service/service.go # slasher/service/service_test.go * proposal and attester store * day to status * comment change * one bucket * Merge branch 'master' of github.com:prysmaticlabs/prysm into attester_proposer_slashing_store # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit. added comments * comment * typo fix * raul review fix * raul review fix full * nishant feedback * test fix * fix tests and remove update gofmt goimports * remove blank line in imports * nishant fixes * comment and fir delete proposer slashings * avoid marshal twice * remove space * Update slasher/db/attester_slashings.go Co-Authored-By: terence tsao <terence@prysmaticlabs.com> * terence feedback Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com> Co-authored-by: terence tsao <terence@prysmaticlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Part of] #3133
Description
slashing proofs storage
design doc
Write why you are making the changes in this pull request
In order to be able to transmit active slashing proofs to beacon nodes upon request we have to store the state of slashing proofs and update it whenever a block with certain proof is being included in the beacon chain.
this storage modules are meant to facilitate this mechanism