Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attester proposer slashing store #4315

Merged
merged 118 commits into from Jan 14, 2020
Merged

Conversation

shayzluf
Copy link
Contributor

@shayzluf shayzluf commented Dec 18, 2019

[Part of] #3133


Description

slashing proofs storage

design doc

Write why you are making the changes in this pull request
In order to be able to transmit active slashing proofs to beacon nodes upon request we have to store the state of slashing proofs and update it whenever a block with certain proof is being included in the beacon chain.
this storage modules are meant to facilitate this mechanism

…alidators

# Conflicts:
#	slasher/flags/flags.go
#	slasher/main.go
#	slasher/service/data_update.go
#	slasher/service/service.go
#	slasher/service/service_test.go
@shayzluf shayzluf added the Ready For Review A pull request ready for code review label Dec 18, 2019
@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@62811e8). Click here to learn what that means.
The diff coverage is 56.32%.

@@            Coverage Diff            @@
##             master    #4315   +/-   ##
=========================================
  Coverage          ?   13.42%           
=========================================
  Files             ?       73           
  Lines             ?     4813           
  Branches          ?        0           
=========================================
  Hits              ?      646           
  Misses            ?     4066           
  Partials          ?      101

@shayzluf shayzluf removed the Ready For Review A pull request ready for code review label Dec 18, 2019
…_proposer_slashing_store

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.

added comments
@shayzluf shayzluf added the Ready For Review A pull request ready for code review label Dec 18, 2019
nisdas
nisdas previously approved these changes Jan 13, 2020
nisdas
nisdas previously approved these changes Jan 13, 2020
Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goimports

slasher/db/proposer_slashings.go Outdated Show resolved Hide resolved
slasher/db/attester_slashings.go Outdated Show resolved Hide resolved
slasher/db/attester_slashings.go Outdated Show resolved Hide resolved
@shayzluf
Copy link
Contributor Author

@terencechain fixed imports

@shayzluf shayzluf merged commit 0b35743 into master Jan 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the attester_proposer_slashing_store branch January 14, 2020 02:13
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 24, 2020
* Merge branch 'master' of github.com:prysmaticlabs/prysm into update_validators

# Conflicts:
#	slasher/flags/flags.go
#	slasher/main.go
#	slasher/service/data_update.go
#	slasher/service/service.go
#	slasher/service/service_test.go

* proposal and attester store

* day to status

* comment change

* one bucket

* Merge branch 'master' of github.com:prysmaticlabs/prysm into attester_proposer_slashing_store
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.

added comments

* comment

* typo fix

* raul review fix

* raul review fix full

* nishant feedback

* test fix

* fix tests and remove update gofmt goimports

* remove blank line in imports

* nishant fixes

* comment and fir delete proposer slashings

* avoid marshal twice

* remove space

* Update slasher/db/attester_slashings.go

Co-Authored-By: terence tsao <terence@prysmaticlabs.com>

* terence feedback

Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
Co-authored-by: terence tsao <terence@prysmaticlabs.com>
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 28, 2020
* Merge branch 'master' of github.com:prysmaticlabs/prysm into update_validators

# Conflicts:
#	slasher/flags/flags.go
#	slasher/main.go
#	slasher/service/data_update.go
#	slasher/service/service.go
#	slasher/service/service_test.go

* proposal and attester store

* day to status

* comment change

* one bucket

* Merge branch 'master' of github.com:prysmaticlabs/prysm into attester_proposer_slashing_store
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.

added comments

* comment

* typo fix

* raul review fix

* raul review fix full

* nishant feedback

* test fix

* fix tests and remove update gofmt goimports

* remove blank line in imports

* nishant fixes

* comment and fir delete proposer slashings

* avoid marshal twice

* remove space

* Update slasher/db/attester_slashings.go

Co-Authored-By: terence tsao <terence@prysmaticlabs.com>

* terence feedback

Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
Co-authored-by: terence tsao <terence@prysmaticlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants