Refactor generated benchmark files to allow for more general usage #4436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…refactor-files
…refactor-files
|
@0xKiwi lint fails |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
Codecov Report
@@ Coverage Diff @@
## master #4436 +/- ##
=========================================
Coverage ? 58.57%
=========================================
Files ? 236
Lines ? 16114
Branches ? 0
=========================================
Hits ? 9438
Misses ? 5301
Partials ? 1375 |
…refactor-files
…refactor-files
0xKiwi
changed the title
rauljordan
previously approved these changes
Jan 16, 2020
shared/benchutil/pregen.go
Outdated
|
|
||
| // ValidatorCount is for declaring how many validators the benchmarks will be | ||
| // performed with. Default is 65536 or 2M ETH staked. | ||
| var ValidatorCount = uint64(65536) |
There was a problem hiding this comment.
Can you change this to genesis validator count?
…refactor-files
terencechain
approved these changes
Jan 17, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
…rysmaticlabs#4436) * Begin to refactor benchmark files to testutil * Complete most of refactoring * Fix file path * gofmt * Fix path * Move generatego to tools/ * Move gen util to tools/benchmark-files-gen * Add comments to pregen funcs * Make function names consistent * Update README * Redo benchmarks with 16384 validators
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
…rysmaticlabs#4436) * Begin to refactor benchmark files to testutil * Complete most of refactoring * Fix file path * gofmt * Fix path * Move generatego to tools/ * Move gen util to tools/benchmark-files-gen * Add comments to pregen funcs * Make function names consistent * Update README * Redo benchmarks with 16384 validators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the SSZ files used for benchmarking and moves them to their own
benchutilfolder.It also moves the tool to generate the benchmark files to
tools/benchmark-files-gen, with added documentation to generate the files if needed.Now any benchmarking tests can just use the pregen state within
benchutil:)