Change database *Index() to use slice #4466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
previously approved these changes
Jan 9, 2020
prestonvanloon
requested changes
Jan 9, 2020
| @@ -27,6 +28,13 @@ func init() { | |||
| params.OverrideBeaconConfig(params.MinimalSpecConfig()) | |||
| } | |||
|
|
|||
| // _pubKey is a helper to generate a well-formed public key. | |||
| func _pubKey(i uint64) []byte { | |||
There was a problem hiding this comment.
Please remove the underscore. Go naming convention is mixedCase and lower case functions are considered private.
There was a problem hiding this comment.
Reason I did that is because the test is in the aggregator package and I didn't want a function used only for testing and in a _test file to potentially be used by functions in the non-test package. Will change it if you're okay with this (there's another one out there in another package I'll change as well).
There was a problem hiding this comment.
The compiler enforces that you can't use code from _test files in non test files so it is safe to do this.
There was a problem hiding this comment.
Cool; never knew that. Updated.
prestonvanloon
approved these changes
Jan 9, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* Change database *Index() to use slice * Remove underscore from helper name
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* Change database *Index() to use slice * Remove underscore from helper name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch change the signature of the validator-related methods in
beacon-chain/db/iface/interface.gofrom taking arrays to taking slices as their argument for the public key.There are a few reasons for doing this. First, every instance of the code that called these functions outside of tests held slices, so wrapped all of the keys in
bytesutil.ToBytes48()to pass the argument which were then all accessed with[:]as the downstream functions also use slices. So this change reduces unnecessary allocations.Second, wrapping the keys hid potential issues with keys of incorrect lengths, as
ToBytes48()will always provide a 48-byte array regardless of the length of the slice. Storing and retrieving keys will now error if they are of an incorrect size.Third, arrays are hard-coded to 48 bytes when we store this value in our configuration parameters and would prefer to use that. The code now checks length against
params.BeaconConfig().BLSPubkeyLengthThe patch also fixes up a number of tests where invalid public keys (e.g.
[]byte{'A'}) were used.