Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused function #4496

Merged
merged 2 commits into from Jan 11, 2020
Merged

Remove unused function #4496

merged 2 commits into from Jan 11, 2020

Conversation

mcdee
Copy link
Contributor

@mcdee mcdee commented Jan 11, 2020

Initial sync's bestFinalized() has been superseded with an upgrade version in p2p/peers; this removed the unused function.

@codecov
Copy link

codecov bot commented Jan 11, 2020

Codecov Report

Merging #4496 into master will increase coverage by 13.73%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           master    #4496       +/-   ##
===========================================
+ Coverage    6.94%   20.68%   +13.73%     
===========================================
  Files         192      189        -3     
  Lines       12891    13055      +164     
===========================================
+ Hits          895     2700     +1805     
+ Misses      11862     9871     -1991     
- Partials      134      484      +350

@prylabs-bulldozer prylabs-bulldozer bot merged commit 7f1900e into prysmaticlabs:master Jan 11, 2020
@mcdee mcdee deleted the rmunused branch January 11, 2020 12:12
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 24, 2020
* Remove unused function
* Merge branch 'master' into rmunused
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 28, 2020
* Remove unused function
* Merge branch 'master' into rmunused
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants