Log Ethereum 1 deposits before chainstart #4499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4499 +/- ##
===========================================
- Coverage 43.6% 20.58% -23.02%
===========================================
Files 193 192 -1
Lines 12899 13211 +312
===========================================
- Hits 5625 2720 -2905
- Misses 6343 10040 +3697
+ Partials 931 451 -480 |
terencechain
requested changes
Jan 11, 2020
| @@ -184,6 +184,13 @@ func (s *Service) ProcessDepositLog(ctx context.Context, depositLog gethTypes.Lo | |||
| "merkleTreeIndex": index, | |||
| }).Debug("Deposit registered from deposit contract") | |||
| validDepositsCount.Inc() | |||
| // Notify users what is going on, from time to time. | |||
| if !s.chainStartData.Chainstarted { | |||
There was a problem hiding this comment.
How is this different than the following log?
https://github.com/prysmaticlabs/prysm/blob/master/beacon-chain/powchain/log_processing.go#L185
Do you want to remove that? They seem similar
There was a problem hiding this comment.
The one you linked provides per-deposit information, including the public key of the deposit. This one provides more of a progress meter, showing only one report every 512 deposits and no detailed information. I think they both have a place.
terencechain
approved these changes
Jan 11, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* Log Ethereum 1 deposits before chainstart * Merge branch 'master' into logdeposits
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* Log Ethereum 1 deposits before chainstart * Merge branch 'master' into logdeposits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide occasional (every 512 deposits) log entries at info level to keep users informed that prysm is still alive and working when users start it up for the first time.
Fixes #4492 and #4498