Cache filtered block tree #4515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4515 +/- ##
=======================================
Coverage 54.62% 54.62%
=======================================
Files 231 231
Lines 15214 15214
=======================================
Hits 8310 8310
Misses 5674 5674
Partials 1230 1230 |
Didn't think it was needed because we recalculate/update the map as a whole.. but better be safe than sorry. Defensive programming 101, will add a mutex |
| filteredBlocks := make(map[[32]byte]*ethpb.BeaconBlock) | ||
| var err error | ||
| if featureconfig.Get().EnableBlockTreeCache { | ||
| s.filteredBlockTreeLock.Lock() |
There was a problem hiding this comment.
RLock? Seems like you could process many readers in parallel with attestations coming in pubsub quickly
Co-Authored-By: Preston Van Loon <preston@prysmaticlabs.com>
…o cache-filtered-tree
…abs/prysm into cache-filtered-tree
prestonvanloon
approved these changes
Jan 13, 2020
rauljordan
approved these changes
Jan 13, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* Cache filtered block tree * Merge refs/heads/master into cache-filtered-tree * Merge refs/heads/master into cache-filtered-tree * Add locks * Merge branch 'cache-filtered-tree' of git+ssh://github.com/prysmaticlabs/prysm into cache-filtered-tree * Confligt * Merge refs/heads/master into cache-filtered-tree * Merge refs/heads/master into cache-filtered-tree * Update shared/featureconfig/flags.go Co-Authored-By: Preston Van Loon <preston@prysmaticlabs.com> * Rlock * Merge branch 'master' of git+ssh://github.com/prysmaticlabs/prysm into cache-filtered-tree * Merge branch 'cache-filtered-tree' of git+ssh://github.com/prysmaticlabs/prysm into cache-filtered-tree
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* Cache filtered block tree * Merge refs/heads/master into cache-filtered-tree * Merge refs/heads/master into cache-filtered-tree * Add locks * Merge branch 'cache-filtered-tree' of git+ssh://github.com/prysmaticlabs/prysm into cache-filtered-tree * Confligt * Merge refs/heads/master into cache-filtered-tree * Merge refs/heads/master into cache-filtered-tree * Update shared/featureconfig/flags.go Co-Authored-By: Preston Van Loon <preston@prysmaticlabs.com> * Rlock * Merge branch 'master' of git+ssh://github.com/prysmaticlabs/prysm into cache-filtered-tree * Merge branch 'cache-filtered-tree' of git+ssh://github.com/prysmaticlabs/prysm into cache-filtered-tree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4509
This PR caches filtered block tree. Instead of calculating the filtered tree on the fly, the cache maintains the tree and update the tree when there's a new post state
The cache is gated by
--cache-filtered-block-tree. Huge improvements on flame 👇Before:
After:
