Revert "Filter attestation with ProcessAttestationNoSignatureVerify" #4529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
approved these changes
Jan 13, 2020
Codecov Report
@@ Coverage Diff @@
## master #4529 +/- ##
===========================================
- Coverage 42.24% 21.13% -21.11%
===========================================
Files 193 192 -1
Lines 13323 12934 -389
===========================================
- Hits 5628 2734 -2894
- Misses 6728 9748 +3020
+ Partials 967 452 -515 |
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
…rysmaticlabs#4529) * Revert "Filter attestation with ProcessAttestationNoSignatureVerify (prysmaticlabs#4513)" This reverts commit 22e01aa.
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
…rysmaticlabs#4529) * Revert "Filter attestation with ProcessAttestationNoSignatureVerify (prysmaticlabs#4513)" This reverts commit 22e01aa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4513
Discussed offline that this could generate blocks that immediately fail. Given that we only mark attestations as "deleted" from the pool on a successful block inclusion, we could end up with a stalled chain until that attestation is no longer valid. We're also not observing much improvement in GetBlock latency times with this change and we believe the bottleneck is in redundant computation of ProposerIndex.