Minor tweaks to GetAttestationData #4533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4533 +/- ##
=========================================
Coverage ? 21.14%
=========================================
Files ? 192
Lines ? 12935
Branches ? 0
=========================================
Hits ? 2735
Misses ? 9748
Partials ? 452 |
nisdas
approved these changes
Jan 14, 2020
nisdas
previously approved these changes
Jan 14, 2020
terencechain
previously approved these changes
Jan 14, 2020
prestonvanloon
dismissed stale reviews from terencechain and nisdas
via
19fc22c
nisdas
approved these changes
Jan 14, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* Maybe bugfix * Maybe bugfix * make GetAttestationData cheaper * clone head state getter return values * Fix tests * fix e2e and revert most changes 😩 Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* Maybe bugfix * Maybe bugfix * make GetAttestationData cheaper * clone head state getter return values * Fix tests * fix e2e and revert most changes 😩 Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove ProcessSlots, it wasn't necessaryMade ProcessSlots only advance to the start slot of the requested epoch.