Add bad peer count #4537
Merged
Add bad peer count #4537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4537 +/- ##
=========================================
Coverage ? 43.28%
=========================================
Files ? 193
Lines ? 12947
Branches ? 0
=========================================
Hits ? 5604
Misses ? 6395
Partials ? 948 |
nisdas
approved these changes
Jan 14, 2020
rauljordan
added
OK to merge
Ready For Review
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* Add bad peer count * Merge branch 'master' into badpeercount * Merge branch 'master' into badpeercount * Merge branch 'master' into badpeercount * Merge branch 'master' into badpeercount
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* Add bad peer count * Merge branch 'master' into badpeercount * Merge branch 'master' into badpeercount * Merge branch 'master' into badpeercount * Merge branch 'master' into badpeercount
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a counter for bad peers to prometheus metrics, and associated function to fetch same. Bad peers are a subset of disconnected peers, but it is useful to know how many peers there are that we don't want to talk to (bad fork version, bad response, etc.) as opposed to those we just aren't talking to (currently unreachable, reached max peers, etc.)