Include Validator Index in GetDuties Response, Update EthereumAPIs #4567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
added
API
rauljordan
requested review from
terencechain,
prestonvanloon,
nisdas,
0xKiwi and
shayzluf
prestonvanloon
previously approved these changes
Jan 16, 2020
terencechain
approved these changes
Jan 16, 2020
Codecov Report
@@ Coverage Diff @@
## master #4567 +/- ##
=========================================
Coverage ? 18.73%
=========================================
Files ? 165
Lines ? 10798
Branches ? 0
=========================================
Hits ? 2023
Misses ? 8425
Partials ? 350 |
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
…rysmaticlabs#4567) * include new patch * add patch and validator indices to duties resp * test passing * move call to validator index * Merge branch 'master' into include-val-idx * do not use wait groups anymore * Merge branch 'include-val-idx' of github.com:prysmaticlabs/prysm into include-val-idx * Update beacon-chain/rpc/validator/assignments_test.go
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
…rysmaticlabs#4567) * include new patch * add patch and validator indices to duties resp * test passing * move call to validator index * Merge branch 'master' into include-val-idx * do not use wait groups anymore * Merge branch 'include-val-idx' of github.com:prysmaticlabs/prysm into include-val-idx * Update beacon-chain/rpc/validator/assignments_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #4379
Description
Write why you are making the changes in this pull request
We notice it is unnecessary for validators to make thousands of requests for validator indices to the beacon node after retrieving duties if we can just include that value in the response.
Write a summary of the changes you are making
This PR uses the latest Ethereum APIs commit prysmaticlabs/ethereumapis@8a785e1 to include this. Fixes the validator client + beacon node, and cleans up some tests.