p2p: Don't mark peer as bad in connection handler #4575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4575 +/- ##
=========================================
- Coverage 47.04% 42.25% -4.8%
=========================================
Files 193 193
Lines 13384 13240 -144
=========================================
- Hits 6297 5594 -703
- Misses 6043 6683 +640
+ Partials 1044 963 -81 |
terencechain
approved these changes
Jan 18, 2020
nisdas
approved these changes
Jan 18, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's already handled here:
prysm/beacon-chain/sync/rpc_status.go
Line 108 in d744aaa
The current implementation might cause the peer to be marked as bad twice and banned quickly.