Improve E2E to be more consistent with timing, and allow for custom flags #4620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… which was previously 4 minutes
Codecov Report
@@ Coverage Diff @@
## master #4620 +/- ##
========================================
Coverage ? 0.93%
========================================
Files ? 48
Lines ? 3415
Branches ? 0
========================================
Hits ? 32
Misses ? 3381
Partials ? 2 |
0xKiwi
changed the title
0xKiwi
requested review from
terencechain and
rauljordan
and removed request for
terencechain
nisdas
approved these changes
Jan 25, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
…lags (prysmaticlabs#4620) * Add committees helper, benchmark, results show 62ms for 8k validators which was previously 4 minutes * Add regression test with same data * fix epoch conversion * lint * undo and lint * Begin work on adding mainnet config benchmark * Try more to get mainnet e2e * Try to fix delay * Get past chainstart on e2e * Try to fix flaky * Get demo config working * Remove unneeded changes * Change how flags are enabled * Lower shard count * Temp skip * Fix e2e * Fix testing to run until last epoch * Fix * Add ending time log and remove att cache flag * Fix ordering * Reenable flag * Change ports from default * Add no log for if there are no err logs * Add block evaluator * Try to improve evaluators * Progress on attestation evaluator * Remove attestation evaluator * Fix e2e Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
…lags (prysmaticlabs#4620) * Add committees helper, benchmark, results show 62ms for 8k validators which was previously 4 minutes * Add regression test with same data * fix epoch conversion * lint * undo and lint * Begin work on adding mainnet config benchmark * Try more to get mainnet e2e * Try to fix delay * Get past chainstart on e2e * Try to fix flaky * Get demo config working * Remove unneeded changes * Change how flags are enabled * Lower shard count * Temp skip * Fix e2e * Fix testing to run until last epoch * Fix * Add ending time log and remove att cache flag * Fix ordering * Reenable flag * Change ports from default * Add no log for if there are no err logs * Add block evaluator * Try to improve evaluators * Progress on attestation evaluator * Remove attestation evaluator * Fix e2e Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the E2E setup slightly to allow for more consistent length time to allow for custom flag for the validators and beacon chain. It also changes all the ports from default to prevent running E2E conflicting with a local node.