Part 4 of proto array fork choice - check nodes viable #4625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Ready For Review
Codecov Report
@@ Coverage Diff @@
## master #4625 +/- ##
=========================================
Coverage ? 22.88%
=========================================
Files ? 6
Lines ? 236
Branches ? 0
=========================================
Hits ? 54
Misses ? 179
Partials ? 3 |
nisdas
reviewed
Jan 23, 2020
Co-Authored-By: Nishant Das <nishdas93@gmail.com>
nisdas
approved these changes
Jan 23, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
…#4625) * Docs * Interface definitions * Fmt and gazelle * Rename interface to interfaces * Define all the type for protoarray * Gaz * Add error types * Add compute delta helper * Compute delta tests * Gaz * Add checking if nodes viable * Test for viable head * Test for non leaf node can lead to viable head * Extra space * Remove fmt print * Update beacon-chain/forkchoice/protoarray/nodes.go Co-Authored-By: Nishant Das <nishdas93@gmail.com> Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Nishant Das <nish1993@hotmail.com>
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
…#4625) * Docs * Interface definitions * Fmt and gazelle * Rename interface to interfaces * Define all the type for protoarray * Gaz * Add error types * Add compute delta helper * Compute delta tests * Gaz * Add checking if nodes viable * Test for viable head * Test for non leaf node can lead to viable head * Extra space * Remove fmt print * Update beacon-chain/forkchoice/protoarray/nodes.go Co-Authored-By: Nishant Das <nishdas93@gmail.com> Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Nishant Das <nish1993@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR checks of the input nodes are viable. "Viable" here means the node's justified epoch and finalized epoch are the same ones in
Store