Allow ListBeaconCommittees API to return previous epoch #4647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xKiwi
requested review from
rauljordan and
terencechain
and removed request for
rauljordan
Codecov Report
@@ Coverage Diff @@
## master #4647 +/- ##
=========================================
Coverage ? 18.43%
=========================================
Files ? 193
Lines ? 13381
Branches ? 0
=========================================
Hits ? 2467
Misses ? 10601
Partials ? 313 |
rauljordan
approved these changes
Jan 25, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
…s#4647) * Allow committees API to request previous epoch * Fix error log * Fix previous epoch test
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
…s#4647) * Allow committees API to request previous epoch * Fix error log * Fix previous epoch test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
ListBeaconCommiteesendpoint to allow requesting the previous epoch of beacon committees without requiring an archival node as the data should be possible to calculate anyways.Also add a regression test to make sure requested previous epoch works.