Replace no-genesis-delay with custom-genesis-delay #4678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
approved these changes
Jan 28, 2020
Codecov Report
@@ Coverage Diff @@
## master #4678 +/- ##
=========================================
Coverage ? 55.36%
=========================================
Files ? 248
Lines ? 18734
Branches ? 0
=========================================
Hits ? 10373
Misses ? 6887
Partials ? 1474 |
rauljordan
added a commit
that referenced
this pull request
Jan 29, 2020
This reverts commit 9149c2e.
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* Change NoGenesisDelay to CustomGenesisDelay * Implement flag * gazelle * Fix docs * Merge branch 'master' of https://github.com/prysmaticlabs/Prysm into custom-genesis-delay * Fix * Gazelle * Add case to fix bad math * Merge branch 'master' into custom-genesis-delay
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* Change NoGenesisDelay to CustomGenesisDelay * Implement flag * gazelle * Fix docs * Merge branch 'master' of https://github.com/prysmaticlabs/Prysm into custom-genesis-delay * Fix * Gazelle * Add case to fix bad math * Merge branch 'master' into custom-genesis-delay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
--no-genesis-delayto--custom-genesis-delayin order to allow a 0 genesis delay but also allow configuring it for E2E and other instances where it might be needed.