Fix validator assignments on slot 0 #4682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xKiwi
requested review from
prestonvanloon,
terencechain,
rauljordan and
nisdas
and removed request for
prestonvanloon
terencechain
previously approved these changes
Jan 29, 2020
terencechain
approved these changes
Jan 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #4682 +/- ##
=========================================
Coverage ? 27.07%
=========================================
Files ? 223
Lines ? 15754
Branches ? 0
=========================================
Hits ? 4265
Misses ? 10756
Partials ? 733 |
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* Fix validator acting upon first slot * Change log to debug * Fix roles at slot 0 * Merge branch 'master' of https://github.com/prysmaticlabs/Prysm into fix-val * Add regression test * Formatting * Add slot ticker regression test
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* Fix validator acting upon first slot * Change log to debug * Fix roles at slot 0 * Merge branch 'master' of https://github.com/prysmaticlabs/Prysm into fix-val * Add regression test * Formatting * Add slot ticker regression test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, assignments at slot 0 are broken. No assignments will be given for slot 0, including attestations which is the normal act. This results in 2 committees being penalized on genesis, having to deal with an effective balance of 31 until they bring their balance up to 32.5.
Also added a regression test to make sure slot 0 doesn't have this issue again.