Cleanup slasher codebase #4698
Merged
Cleanup slasher codebase #4698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cleanup-slasher
…cleanup-slasher
Codecov Report
@@ Coverage Diff @@
## master #4698 +/- ##
=========================================
Coverage ? 12.26%
=========================================
Files ? 77
Lines ? 6260
Branches ? 0
=========================================
Hits ? 768
Misses ? 5360
Partials ? 132 |
…o cleanup-slasher
…cleanup-slasher
rauljordan
reviewed
Feb 3, 2020
| var status SlashingStatus | ||
| var found bool | ||
| key := encodeTypeRoot(SlashingType(Attestation), root) | ||
| root, err := hashutil.HashProto(slashing) |
There was a problem hiding this comment.
this isnt really a root, just a hash - maybe rename?
slasher/service/data_update.go
Outdated
| @@ -14,7 +14,7 @@ import ( | |||
| "google.golang.org/grpc/status" | |||
| ) | |||
|
|
|||
| // finalisedChangeUpdater this is a stub for the comming PRs #3133 | |||
| // finalisedChangeUpdater this is a stub for the coming PRs #3133 | |||
shayzluf
reviewed
Feb 4, 2020
slasher/db/min_max_span.go
Outdated
| @@ -15,28 +15,28 @@ var highestValidatorIdx uint64 | |||
| func saveToDB(validatorIdx uint64, _ uint64, value interface{}, cost int64) { | |||
| log.Tracef("evicting span map for validator id: %d", validatorIdx) | |||
|
|
|||
| err := d.batch(func(tx *bolt.Tx) error { | |||
| err := d.update(func(tx *bolt.Tx) error { | |||
There was a problem hiding this comment.
this method might be called from many go routines maybe its better to keep it batch
…cleanup-slasher
…o cleanup-slasher
rauljordan
approved these changes
Feb 4, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* First wave of changes * More changes * More renames, changes * Fix errors * Merge branch 'master' of https://github.com/prysmaticlabs/Prysm into cleanup-slasher * Fix errors, more cleaning * Merge branch 'master' of https://github.com/prysmaticlabs/Prysm into cleanup-slasher * Merge branch 'master' into cleanup-slasher * fix err * Merge branch 'cleanup-slasher' of https://github.com/0xKiwi/Prysm into cleanup-slasher * Fix strings * More cleanup * Merge branch 'master' of https://github.com/prysmaticlabs/Prysm into cleanup-slasher * Fix interface * Fix * Merge branch 'master' into cleanup-slasher * Merge branch 'master' into cleanup-slasher * Merge branch 'master' into cleanup-slasher * Address comments * Merge branch 'master' of https://github.com/prysmaticlabs/Prysm into cleanup-slasher * Merge branch 'cleanup-slasher' of https://github.com/0xKiwi/Prysm into cleanup-slasher
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* First wave of changes * More changes * More renames, changes * Fix errors * Merge branch 'master' of https://github.com/prysmaticlabs/Prysm into cleanup-slasher * Fix errors, more cleaning * Merge branch 'master' of https://github.com/prysmaticlabs/Prysm into cleanup-slasher * Merge branch 'master' into cleanup-slasher * fix err * Merge branch 'cleanup-slasher' of https://github.com/0xKiwi/Prysm into cleanup-slasher * Fix strings * More cleanup * Merge branch 'master' of https://github.com/prysmaticlabs/Prysm into cleanup-slasher * Fix interface * Fix * Merge branch 'master' into cleanup-slasher * Merge branch 'master' into cleanup-slasher * Merge branch 'master' into cleanup-slasher * Address comments * Merge branch 'master' of https://github.com/prysmaticlabs/Prysm into cleanup-slasher * Merge branch 'cleanup-slasher' of https://github.com/0xKiwi/Prysm into cleanup-slasher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is me going through the slasher client and cleaning up/improving whatever I find. Includes function renames, improvements to the codebase and readability improvements.