Relegate some p2p messages #4725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
approved these changes
Feb 3, 2020
Codecov Report
@@ Coverage Diff @@
## master #4725 +/- ##
==========================================
+ Coverage 43.38% 43.66% +0.28%
==========================================
Files 231 204 -27
Lines 17484 15298 -2186
==========================================
- Hits 7585 6680 -905
+ Misses 8647 7471 -1176
+ Partials 1252 1147 -105 |
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* Relegate some p2p messages
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* Relegate some p2p messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
p2p is quite chatty when it has connection requests from peers it does not want to talk to. This patch changes a number of log entries from debug to trace, to reduce this.
(Note that when libp2p takes application-layer hints as to which connections to proceed with these could be returned to debug, as at that point they will point out real issues with the handshake process).