Misc fork choice improvements #4744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4744 +/- ##
===========================================
+ Coverage 12.26% 42.94% +30.67%
===========================================
Files 77 204 +127
Lines 6260 15341 +9081
===========================================
+ Hits 768 6588 +5820
- Misses 5360 7638 +2278
- Partials 132 1115 +983 |
rauljordan
reviewed
Feb 4, 2020
| // or get_ancestor(store, store.justified_checkpoint.root, finalized_slot) != store.finalized_checkpoint.root | ||
| // ): | ||
| // store.justified_checkpoint = state.current_justified_checkpoint | ||
| func (s *Service) finalizedNewJustified(ctx context.Context, state *stateTrie.BeaconState) error { |
There was a problem hiding this comment.
can we rename to something more informative? finalizedImpliesNewJustifiedCheckpoint or something like that
rauljordan
approved these changes
Feb 4, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* Added missing spec implementation * Use it * Rename * Merge branch 'master' into update-justified
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* Added missing spec implementation * Use it * Rename * Merge branch 'master' into update-justified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a few more checks after rereading the spec. This should improve new fork choice health