Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blockchain metrics #4747

Merged
merged 4 commits into from Feb 4, 2020
Merged

Update blockchain metrics #4747

merged 4 commits into from Feb 4, 2020

Conversation

terencechain
Copy link
Member

@terencechain terencechain commented Feb 4, 2020

Added blockchain/metrics package to display state transition metrics used by blockchain processing routine or blockchain/forkchoice routine which is soon to be depreated

@terencechain terencechain self-assigned this Feb 4, 2020
@terencechain terencechain added the Ready For Review A pull request ready for code review label Feb 4, 2020
@terencechain terencechain changed the title Update blockchain pkg metrics the canonical one Update blockchain metrics Feb 4, 2020
rauljordan
rauljordan previously approved these changes Feb 4, 2020
@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #4747 into master will decrease coverage by 7.96%.
The diff coverage is 64.28%.

@@            Coverage Diff             @@
##           master    #4747      +/-   ##
==========================================
- Coverage   52.65%   44.69%   -7.97%     
==========================================
  Files         243      203      -40     
  Lines       18147    15275    -2872     
==========================================
- Hits         9556     6827    -2729     
- Misses       7152     7299     +147     
+ Partials     1439     1149     -290

@prylabs-bulldozer prylabs-bulldozer bot merged commit 8c5c735 into master Feb 4, 2020
@delete-merged-branch delete-merged-branch bot deleted the update-metrics branch February 4, 2020 22:57
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 24, 2020
* Make new metrics the canonical one
* Both threads share same metric set
* Comments
* Fix vis
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 28, 2020
* Make new metrics the canonical one
* Both threads share same metric set
* Comments
* Fix vis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants