Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB: Do not allow attempts to save a nil state #4758

Merged
merged 2 commits into from Feb 5, 2020
Merged

Conversation

prestonvanloon
Copy link
Member

As title describes, return an error if there is a nil state attempted to be saved.

@prestonvanloon prestonvanloon added Bug Something isn't working Ready For Review A pull request ready for code review labels Feb 5, 2020
@prestonvanloon prestonvanloon added the Priority: High High priority item label Feb 5, 2020
@codecov
Copy link

codecov bot commented Feb 5, 2020

Codecov Report

Merging #4758 into master will decrease coverage by 44.63%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #4758       +/-   ##
==========================================
- Coverage   50.15%   5.51%   -44.64%     
==========================================
  Files         203     202        -1     
  Lines       15284   15275        -9     
==========================================
- Hits         7665     843     -6822     
- Misses       6389   14314     +7925     
+ Partials     1230     118     -1112

@prestonvanloon prestonvanloon merged commit c496170 into master Feb 5, 2020
@delete-merged-branch delete-merged-branch bot deleted the nil-state-check branch February 5, 2020 19:52
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 24, 2020
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Priority: High High priority item Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants