Update higherThanFinalized in the loop #4761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4761 +/- ##
==========================================
- Coverage 43.64% 43.61% -0.04%
==========================================
Files 203 203
Lines 15278 15280 +2
==========================================
- Hits 6668 6664 -4
- Misses 7485 7491 +6
Partials 1125 1125 |
rauljordan
approved these changes
Feb 5, 2020
prestonvanloon
approved these changes
Feb 5, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* Update higherThanFinalized in the loop * Addded a test * Fixed test * Merge branch 'master' into update-finalized
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* Update higherThanFinalized in the loop * Addded a test * Fixed test * Merge branch 'master' into update-finalized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We never updated boolean variable
higherThanFinalizedin the loop so the loop traversed all the way back to genesis slot 馃樃Added a regression test. Thanks @prestonvanloon for the catch