Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block tree enhancements #4764

Merged
merged 4 commits into from Feb 5, 2020
Merged

Block tree enhancements #4764

merged 4 commits into from Feb 5, 2020

Conversation

terencechain
Copy link
Member

@terencechain terencechain commented Feb 5, 2020 •
edited

  • Added new field Votes (ie the number of validators)
  • Added color green for head block
  • ETH -> Gwei is 1e9 not 10e9

@terencechain terencechain self-assigned this Feb 5, 2020
@terencechain terencechain added Forkchoice Enhancement New feature or request labels Feb 5, 2020
@codecov
Copy link

codecov bot commented Feb 5, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@6a13024). Click here to learn what that means.
The diff coverage is 33.33%.

@@            Coverage Diff            @@
##             master    #4764   +/-   ##
=========================================
  Coverage          ?   43.63%           
=========================================
  Files             ?      203           
  Lines             ?    15284           
  Branches          ?        0           
=========================================
  Hits              ?     6669           
  Misses            ?     7490           
  Partials          ?     1125

@rauljordan rauljordan merged commit c6e3d67 into master Feb 5, 2020
@rauljordan rauljordan deleted the better-tree branch February 5, 2020 23:31
@terencechain terencechain restored the better-tree branch February 6, 2020 00:20
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 24, 2020
@terencechain @cryptomental
Block tree enhancements (prysmaticlabs#4764)
346858f 
* Add votes, correct conversion and green for head

* Starting testing

* Fix for run time
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 28, 2020
@terencechain @cryptomental
Block tree enhancements (prysmaticlabs#4764)
b2ded8b 
* Add votes, correct conversion and green for head

* Starting testing

* Fix for run time
@terencechain terencechain deleted the better-tree branch July 11, 2020 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauljordan rauljordan rauljordan approved these changes

@0xKiwi 0xKiwi 0xKiwi approved these changes

Assignees

@terencechain terencechain

Labels
Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@terencechain @rauljordan @0xKiwi