Disable forkchoice pre-processing of attestations #4774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
added
Enhancement
prestonvanloon
requested review from
rauljordan,
shayzluf,
0xKiwi,
terencechain and
nisdas
terencechain
approved these changes
Feb 6, 2020
Codecov Report
@@ Coverage Diff @@
## master #4774 +/- ##
===========================================
- Coverage 56.79% 29.51% -27.28%
===========================================
Files 249 229 -20
Lines 18845 17078 -1767
===========================================
- Hits 10703 5041 -5662
- Misses 6574 11198 +4624
+ Partials 1568 839 -729 |
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* Disable forkchoice pre-processing of attestations * space * gaz
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* Disable forkchoice pre-processing of attestations * space * gaz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a bad attestation makes it into fork choice, it may be aggregated causing the whole attestation to become bad. Until we have a better mechanism to prevent bad attestations from corrupting good ones in fork choice, we will not aggregate them by default. The purpose of the aggregation is to reduce the number of distinct aggregations processed through fork choice. While this type of optimization is desired, better to be safe for the time being.
Maybe supersedes #4660