Slasher proto and function renames #4797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4797 +/- ##
========================================
Coverage ? 3.35%
========================================
Files ? 78
Lines ? 6433
Branches ? 0
========================================
Hits ? 216
Misses ? 6179
Partials ? 38 |
| @@ -25,8 +25,8 @@ func unmarshalIdxAtt(enc []byte) (*ethpb.IndexedAttestation, error) { | |||
| return protoIdxAtt, nil | |||
| } | |||
|
|
|||
| func unmarshalValIDsToIdxAttList(enc []byte) (*slashpb.ValidatorIDToIdxAttList, error) { | |||
| protoIdxAtt := &slashpb.ValidatorIDToIdxAttList{} | |||
| func unmarshalCompressedIdxAttList(enc []byte) (*slashpb.CompressedIdxAttList, error) { | |||
There was a problem hiding this comment.
CompressedIdx sounds too vague imo, is it validator index? attestation index? block index?... etc
There was a problem hiding this comment.
It is an indexed attestation, but the AttestationData is changed to its []byte attestation data root. That's why I refer to it as "compressed".
slasher/service/data_update.go
Outdated
| } | ||
| } | ||
|
|
||
| // finalizedChangeUpdater this is a stub for the coming PRs #3133 |
There was a problem hiding this comment.
Suggested change
| // finalizedChangeUpdater this is a stub for the coming PRs #3133 | |
| // finalizedChangeUpdater this is a stub for the coming PRs #3133. |
slasher/service/data_update.go
Outdated
| } | ||
|
|
||
| // finalizedChangeUpdater this is a stub for the coming PRs #3133 | ||
| // Store validator index to public key map Validate attestation signature. |
There was a problem hiding this comment.
Suggested change
| // Store validator index to public key map Validate attestation signature. | |
| // Store validator index to public key map to validate attestation signature. |
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* Rename elements for clarity * Merge branch 'master' of https://github.com/prysmaticlabs/Prysm into slasher-renames * Fix test * Rename more functions * Cleanup * Fix logs * Merge branch 'master' of https://github.com/prysmaticlabs/Prysm into slasher-renames * Reorganize and clean up logs * Address comments * Add comments
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* Rename elements for clarity * Merge branch 'master' of https://github.com/prysmaticlabs/Prysm into slasher-renames * Fix test * Rename more functions * Cleanup * Fix logs * Merge branch 'master' of https://github.com/prysmaticlabs/Prysm into slasher-renames * Reorganize and clean up logs * Address comments * Add comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames and cleans up the slasher further to reduce confusion.
Renames:
ValidatorIDToIdxAtt->CompressedIdxAttValidatorIDToIdxAttList->CompressedIdxAttListBlockHeader()->BlockHeaders()dataForDetection()->attsAndCommitteesForEpoch()slasherOldAttestationFeeder()->historicalAttestationFeeder()Changed
indexedAttestationsIndicesBuckettocompressedIdxAttsBucketdetectAttestation()split intoconvertToIndexed()anddetectSlashings()Changes the
ClearDB()function to only clear the slasher db, not the whole DB folder.