New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature flag to disable head update on attestation basis #4802
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4802 +/- ##
=======================================
Coverage 56.87% 56.87%
=======================================
Files 246 246
Lines 18394 18394
=======================================
Hits 10462 10462
Misses 6456 6456
Partials 1476 1476 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add it as a feature flag? Like we have --disable-strict-attestation-pubsub-verification
which gives us the option to disable this in an emergency.
this is a good idea, I'm leaning towards default behavior is compute head on per attestation, the feature flag will disable that. It's generally good for the node to get head updated as frequently incoming attestation if there's not much penalties to go with it |
…o dont-update-head-on-new-att
…o dont-update-head-on-new-att
Computing head for every new attestation is a nice to have but may be too excessive, we can change the strategy to updating head every second. Opening this as an option to not compute head on every attestation.
Another option is to remove the tracing for the following methods. They seem to be the main bottlenecks.