Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent panic on wrong interface conversion #4803

Merged
merged 2 commits into from Feb 9, 2020
Merged

Conversation

prestonvanloon
Copy link
Member

Resolves #4801

@prestonvanloon prestonvanloon added Bug Something isn't working Ready For Review A pull request ready for code review labels Feb 9, 2020
@codecov
Copy link

codecov bot commented Feb 9, 2020

Codecov Report

Merging #4803 into master will decrease coverage by 14.31%.
The diff coverage is 33.33%.

@@             Coverage Diff             @@
##           master    #4803       +/-   ##
===========================================
- Coverage   43.45%   29.14%   -14.32%     
===========================================
  Files         200      199        -1     
  Lines       15024    14841      -183     
===========================================
- Hits         6529     4325     -2204     
- Misses       7443     9784     +2341     
+ Partials     1052      732      -320

@prylabs-bulldozer prylabs-bulldozer bot merged commit 7e0d050 into master Feb 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-4801 branch February 9, 2020 08:41
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 24, 2020
* Prevent panic on wrong interface conversion
* remove import
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 28, 2020
* Prevent panic on wrong interface conversion
* remove import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: interface conversion during syn
2 participants