Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase check point state cache size to 10 #4818

Merged
merged 1 commit into from Feb 10, 2020

Conversation

terencechain
Copy link
Member

Previous size 4 was not enough given more forks than expected in current testnet.

# HELP check_point_state_cache_hit The number of check point state requests that are present in the cache.
check_point_state_cache_hit 133643
# HELP check_point_statecache_miss The number of check point state requests that aren't present in the cache.
check_point_statecache_miss 2762

Increased the 10:

# HELP committee_cache_hit The number of committee requests that are present in the cache.
committee_cache_hit 135609
# HELP committee_cache_miss The number of committee requests that aren't present in the cache.
committee_cache_miss 12

Improved hit ratio from 97.9% to 99.9%, it may not seem like a lot but that's a saving of 2000 extra hash tree root and epoch transition of a mainnet state

@codecov
Copy link

codecov bot commented Feb 10, 2020

Codecov Report

Merging #4818 into master will increase coverage by 13.19%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #4818       +/-   ##
===========================================
+ Coverage   43.57%   56.77%   +13.19%     
===========================================
  Files         230      247       +17     
  Lines       17296    18263      +967     
===========================================
+ Hits         7537    10369     +2832     
+ Misses       8547     6431     -2116     
- Partials     1212     1463      +251

@terencechain terencechain merged commit 1a5c515 into master Feb 10, 2020
@delete-merged-branch delete-merged-branch bot deleted the inc-checkpoint-state-cache-size branch February 10, 2020 18:14
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 24, 2020
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants