fixed panic: runtime error: integer divide by zero #4777

[aranhaagency]

add Simple checker for integer divide

[Part of|Resolves] #4777

---

[claassistantio]

All committers have signed the CLA.

[rauljordan]

Hi @aranhaagency sorry for the misunderstanding, but the problem isn't that we're overflowing the max value of an int - the problem is we're accessing an element out of range in the list. Here's the issue:

list = [a, b, c, d, e]

I want to access element 24:

item := list[24]
panic: index 24 out of range in list of length 5

That's the issue we're trying to solve. What you can do is generate a random number again in a for loop until you generate one that is < the length of the list. It shouldn't take many retries to get a number that doesn't go out of range.

[aranhaagency]

Hi @rauljordan, Thanks.
for the feedback I will implement.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@b3a3d02). Click here to learn what that means.
The diff coverage is 61.7%.

@@            Coverage Diff            @@
##             master    #4823   +/-   ##
=========================================
  Coverage          ?   57.46%           
=========================================
  Files             ?      255           
  Lines             ?    19264           
  Branches          ?        0           
=========================================
  Hits              ?    11071           
  Misses            ?     6677           
  Partials          ?     1516

[terencechain]

@aranhaagency handled it since this issue is more pressuring to current testnet. Thanks for starting!