Revert state copy PR #4811 #4825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
approved these changes
Feb 11, 2020
nisdas
approved these changes
Feb 11, 2020
Codecov Report
@@ Coverage Diff @@
## master #4825 +/- ##
==========================================
+ Coverage 44.07% 56.58% +12.5%
==========================================
Files 203 247 +44
Lines 15179 18294 +3115
==========================================
+ Hits 6690 10351 +3661
+ Misses 7411 6480 -931
- Partials 1078 1463 +385 |
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* Revert "Add mempool feature flag (prysmaticlabs#4824)" This reverts commit b3f2a33. * Revert "Optimize Copying of Fields (prysmaticlabs#4811)" This reverts commit 4f654d3.
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* Revert "Add mempool feature flag (prysmaticlabs#4824)" This reverts commit b3f2a33. * Revert "Optimize Copying of Fields (prysmaticlabs#4811)" This reverts commit 4f654d3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seems to be causing many state root verification issues.
This also reverts #4824 which added a feature flag to help mitigate the issue unsuccessfully.