Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont Initialize Zeroed Out State #4863

Merged
merged 10 commits into from Feb 14, 2020
Merged

Dont Initialize Zeroed Out State #4863

merged 10 commits into from Feb 14, 2020

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Feb 14, 2020

Fixes panic when running the node, after pre-genesis state is deleted.

@codecov
Copy link

codecov bot commented Feb 14, 2020

Codecov Report

Merging #4863 into master will decrease coverage by 8.75%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #4863      +/-   ##
==========================================
- Coverage   56.16%   47.41%   -8.76%     
==========================================
  Files         256      203      -53     
  Lines       19160    15220    -3940     
==========================================
- Hits        10761     7216    -3545     
+ Misses       6895     6875      -20     
+ Partials     1504     1129     -375

@nisdas nisdas changed the title Dont initialize map with empty registry Dont Initialize Zeroed Out State Feb 14, 2020
@nisdas nisdas added the Ready For Review A pull request ready for code review label Feb 14, 2020
@prylabs-bulldozer prylabs-bulldozer bot merged commit 214121b into master Feb 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the mapFix branch February 14, 2020 12:19
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 24, 2020
* dont initialize map with empty registry
* check zeroed pointer
* check zeroed pointer
* imports
* gaz
* better check
* gaz
* fix it finally
* finally fix it
* gaz
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 28, 2020
* dont initialize map with empty registry
* check zeroed pointer
* check zeroed pointer
* imports
* gaz
* better check
* gaz
* fix it finally
* finally fix it
* gaz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants