Save Attestations In Initial Sync if Archive Enabled #4895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
added
Enhancement
Codecov Report
@@ Coverage Diff @@
## master #4895 +/- ##
=========================================
Coverage ? 44.27%
=========================================
Files ? 203
Lines ? 15287
Branches ? 0
=========================================
Hits ? 6768
Misses ? 7427
Partials ? 1092 |
terencechain
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4836
Description
Write why you are making the changes in this pull request
We are not saving attestations to the attestations bucket on initial sync even if --archive was enabled. This functionality is important for slasher to fetch historical attestations.