Utilise a Flag to Toggle With the GC #4897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4897 +/- ##
==========================================
+ Coverage 47.54% 47.56% +0.01%
==========================================
Files 203 204 +1
Lines 15288 15300 +12
==========================================
+ Hits 7269 7277 +8
- Misses 6879 6883 +4
Partials 1140 1140 |
terencechain
approved these changes
Feb 18, 2020
|
When would someone want to change this from the default? |
|
@prestonvanloon When they are running the node on a device with restricted amount of memory. Ex: Pi 4. Making the GC more aggressive can prevent OOMs from being triggered |
| @@ -126,6 +127,7 @@ func main() { | |||
| } | |||
| } | |||
|
|
|||
| runtimeDebug.SetGCPercent(ctx.GlobalInt(flags.SetGCPercent.Name)) | |||
There was a problem hiding this comment.
This should only be set if the flag is set, otherwise we are overriding the behavior of the environment variable
The initial setting is the value of the GOGC environment variable at startup, or 100 if the variable is not set.
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* set flag * Merge refs/heads/master into setGC
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* set flag * Merge refs/heads/master into setGC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally a part of #4844
This allows nodes to toggle with the percentage of newly allocated data to live data that the GC is triggered to run again.