Handing pending atts if they dont have the state

[terencechain]

Here's the problem, when a node receives an attestation and it doesn't have the block. It requests the block. It will then go ahead to validate the signature in sync without waiting for state to be processed. Breaking this down into time line:

1.)

[2020-02-18 09:23:15]  INFO blockchain: Executing state transition on block root=0x6b34ab0d... slot=286016

2.)

[2020-02-18 09:23:16] ERROR blockchain: Failed to validate attestation error=pre state of target block 286016 does not exist
[2020-02-18 09:23:16] ERROR blockchain: Failed to validate attestation error=pre state of target block 286016 does not exist
[2020-02-18 09:23:16] ERROR blockchain: Failed to validate attestation error=pre state of target block 286016 does not exist
[2020-02-18 09:23:16] ERROR blockchain: Failed to validate attestation error=pre state of target block 286016 does not exist
[2020-02-18 09:23:16] ERROR blockchain: Failed to validate attestation error=pre state of target block 286016 does not exist
[2020-02-18 09:23:16] ERROR blockchain: Failed to validate attestation error=pre state of target block 286016 does not exist
[2020-02-18 09:23:16] ERROR blockchain: Failed to validate attestation error=pre state of target block 286016 does not exist
[2020-02-18 09:23:16] ERROR blockchain: Failed to validate attestation error=pre state of target block 286016 does not exist
[2020-02-18 09:23:16] ERROR blockchain: Failed to validate attestation error=pre state of target block 286016 does not exist
[2020-02-18 09:23:16] ERROR blockchain: Failed to validate attestation error=pre state of target block 286016 does not exist
[2020-02-18 09:23:16] ERROR blockchain: Failed to validate attestation error=pre state of target block 286016 does not exist
[2020-02-18 09:23:16] ERROR blockchain: Failed to validate attestation error=pre state of target block 286016 does not exist
[2020-02-18 09:23:16] ERROR blockchain: Failed to validate attestation error=pre state of target block 286016 does not exist
[2020-02-18 09:23:16] ERROR blockchain: Failed to validate attestation error=pre state of target block 286016 does not exist

3.)

[2020-02-18 09:23:16]  INFO blockchain: Starting next epoch epoch=8938 finalizedEpoch=8934 justifiedEpoch=8936 previousJustifiedEpoch=8936
[2020-02-18 09:23:16]  INFO blockchain: Validator registry information activeValidators=41660 averageBalance=3.17437 ETH totalValidators=41667
[2020-02-18 09:23:16]  INFO blockchain: Finished applying state transition attestations=1 deposits=0 slot=286016

3 needs to happen before 2. This PR adds the HasState check around pending attestation queue to ensure the signature validation has the state in the DB

[codecov]

Codecov Report

Merging #4904 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4904   +/-   ##
=======================================
  Coverage   29.13%   29.13%           
=======================================
  Files         206      206           
  Lines       15674    15674           
=======================================
  Hits         4566     4566           
  Misses      10308    10308           
  Partials      800      800