Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attestations in pool count metrics #4930

Merged
merged 4 commits into from Feb 23, 2020
Merged

Conversation

terencechain
Copy link
Member

@terencechain terencechain commented Feb 23, 2020

Part of #4929

This PR adds metrics for the total count of each aggregated and unaggregated attestations in pool.

Will be monitoring this tonight. Here's preliminary stats mine after 20 mins...
aggregated_attestations_in_pool_count 805

@terencechain terencechain self-assigned this Feb 23, 2020
@terencechain terencechain added the Ready For Review A pull request ready for code review label Feb 23, 2020
@codecov
Copy link

codecov bot commented Feb 23, 2020

Codecov Report

Merging #4930 into master will increase coverage by 35.43%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           master    #4930       +/-   ##
===========================================
+ Coverage   10.01%   45.45%   +35.43%     
===========================================
  Files          81      209      +128     
  Lines        6871    15953     +9082     
===========================================
+ Hits          688     7251     +6563     
- Misses       6081     7466     +1385     
- Partials      102     1236     +1134

@terencechain terencechain added the Enhancement New feature or request label Feb 23, 2020
@prylabs-bulldozer prylabs-bulldozer bot merged commit 2e56a59 into master Feb 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the att-pool-metrics branch February 23, 2020 22:30
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 24, 2020
* Add metrics
* Use it
* Use it
* Expose getters
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 28, 2020
* Add metrics
* Use it
* Use it
* Expose getters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants