Prepare spanner for double vote detection and fix a few bugs #4940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4940 +/- ##
========================================
Coverage ? 4.04%
========================================
Files ? 71
Lines ? 6130
Branches ? 0
========================================
Hits ? 248
Misses ? 5862
Partials ? 20 |
0xKiwi
changed the title
…slasher-change-to-target
…Prysm into slasher-change-to-target
0xKiwi
changed the title
0xKiwi
changed the title
0xKiwi
changed the title
0xKiwi
changed the title
shayzluf
reviewed
Feb 25, 2020
shayzluf
reviewed
Feb 25, 2020
rauljordan
approved these changes
Feb 26, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
…iclabs#4940) * Rename vars for clarity * Change spanner to take target epoch as key * Fix tests, add multiple val test * Fixes * Change the spanner to take in att on detect * Add back proto diagram tests * Remove unneeded comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4836
This PR goes through the spanner and prepares it for the changes needed to catch double voting. Mainly test additions.
Detailed: https://hackmd.prylabs.network/EcYUo5koQhmWW0_pSlPHSQ