Move blockchain service metrics package #4959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Enhancement
0xKiwi
approved these changes
Feb 27, 2020
Codecov Report
@@ Coverage Diff @@
## master #4959 +/- ##
=========================================
Coverage ? 44.77%
=========================================
Files ? 207
Lines ? 16030
Branches ? 0
=========================================
Hits ? 7177
Misses ? 7617
Partials ? 1236 |
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* Moved metrics package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metricswas its own package because we had some weird dependency between old fork choice processing and proto array fork choice processing. Since we deleted old fork choice, this PR movedmetricsback to block chain service package so it's nicely contained