Add ProtecingKeymanager interface and calls #4982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4982 +/- ##
=======================================
Coverage 14.40% 14.40%
=======================================
Files 239 239
Lines 18283 18283
=======================================
Hits 2633 2633
Misses 15245 15245
Partials 405 405 |
terencechain
approved these changes
Mar 3, 2020
rauljordan
approved these changes
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a
ProtectingKeymanagerinterface and related calls. This interface can be implemented by a keymanager that protects its clients against creating multiple attestations or proposals that could cause slashing events (sample implementation being worked on separately).