Change slasher cache to LRU cache #5037
Conversation
slasher/cache/cache.go
Outdated
| @@ -0,0 +1,73 @@ | |||
| package cache | |||
There was a problem hiding this comment.
perhaps make the name cache.go more specific, when person B comes in and implements a new cache for other functionality, they don't have to worry about changing both
Codecov Report
@@ Coverage Diff @@
## master #5037 +/- ##
=========================================
Coverage ? 14.87%
=========================================
Files ? 98
Lines ? 7389
Branches ? 0
=========================================
Hits ? 1099
Misses ? 6160
Partials ? 130 |
…slasher-change-cache
0xKiwi
changed the title
slasher/cache/span_cache.go
Outdated
|
|
||
| // SaveAllToDB removes all keys from the SpanCache. | ||
| func (c *EpochSpansCache) SaveAllToDB() { | ||
| //c.cache.Keys() |
There was a problem hiding this comment.
Whoops, was working on that to replace the onEvict risettro has. Will fill it in.
slasher/cache/span_cache.go
Outdated
| } | ||
|
|
||
| // Delete removes an epoch from the cache and returns if it existed or not. | ||
| func (c *EpochSpansCache) Delete(epoch uint64) (present bool) { |
There was a problem hiding this comment.
why (present bool)? instead of bool?, doesn't look like the standard convention to me
There was a problem hiding this comment.
Might be confusing what the return bools mean without context, but it's mentioned in the comment too
slasher/detection/service.go
Outdated
| @@ -83,11 +83,11 @@ func (ds *Service) Start() { | |||
|
|
|||
| // The detection service runs detection on all historical | |||
| // chain data since genesis. | |||
| go ds.detectHistoricalChainData(ds.ctx) | |||
| //go ds.detectHistoricalChainData(ds.ctx) | |||
There was a problem hiding this comment.
Commented out in Raul's PR. Not functioning at the moment and gets in the way of testing live detection.
Part of #4836
This PR changes the risettro LFU cache to a LRU cache which better matches our use case.