Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change detection and updating in Slasher to per attestation #5043

Merged
merged 21 commits into from Mar 9, 2020

Conversation

0xKiwi
Copy link
Contributor

@0xKiwi 0xKiwi commented Mar 8, 2020

Part of #4836

This PR modifies how updating and detection is performed on the slasher by changing it to perform the actions on a per attestation basis, rather than a per validating indice basis.

This gives us less overhead, less DB locks, and makes detection much simpler.

@codecov
Copy link

codecov bot commented Mar 8, 2020

Codecov Report

Merging #5043 into master will decrease coverage by 33.85%.
The diff coverage is 77.90%.

@@             Coverage Diff             @@
##           master    #5043       +/-   ##
===========================================
- Coverage   44.08%   10.23%   -33.86%     
===========================================
  Files         214       99      -115     
  Lines       16683     7444     -9239     
===========================================
- Hits         7355      762     -6593     
+ Misses       8031     6586     -1445     
+ Partials     1297       96     -1201     

slasher/detection/attestations/spanner_test.go Outdated Show resolved Hide resolved
slasher/detection/attestations/spanner_test.go Outdated Show resolved Hide resolved
slasher/detection/attestations/spanner_test.go Outdated Show resolved Hide resolved
slasher/detection/detect.go Outdated Show resolved Hide resolved
@rauljordan rauljordan merged commit b633dfe into prysmaticlabs:master Mar 9, 2020
@0xKiwi 0xKiwi deleted the slasher-batch-updating branch March 15, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants