New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change detection and updating in Slasher to per attestation #5043
Merged
rauljordan
merged 21 commits into
prysmaticlabs:master
from
0xKiwi:slasher-batch-updating
Mar 9, 2020
Merged
Change detection and updating in Slasher to per attestation #5043
rauljordan
merged 21 commits into
prysmaticlabs:master
from
0xKiwi:slasher-batch-updating
Mar 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5043 +/- ##
===========================================
- Coverage 44.08% 10.23% -33.86%
===========================================
Files 214 99 -115
Lines 16683 7444 -9239
===========================================
- Hits 7355 762 -6593
+ Misses 8031 6586 -1445
+ Partials 1297 96 -1201 |
…slasher-batch-updating
rauljordan
reviewed
Mar 9, 2020
… slasher-batch-updating
… slasher-batch-updating
rauljordan
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4836
This PR modifies how updating and detection is performed on the slasher by changing it to perform the actions on a per attestation basis, rather than a per validating indice basis.
This gives us less overhead, less DB locks, and makes detection much simpler.