Verify Slashing Signatures Before Putting Into Blocks #5071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
added
Priority: Critical
Codecov Report
@@ Coverage Diff @@
## master #5071 +/- ##
==========================================
- Coverage 44.79% 43.52% -1.28%
==========================================
Files 216 215 -1
Lines 16811 16749 -62
==========================================
- Hits 7531 7290 -241
- Misses 7982 8195 +213
+ Partials 1298 1264 -34 |
rauljordan
requested review from
shayzluf,
terencechain,
nisdas,
0xKiwi,
farazdagi and
prestonvanloon
| "errors" | ||
| "fmt" | ||
| "sort" | ||
|
|
||
| ethpb "github.com/prysmaticlabs/ethereumapis/eth/v1alpha1" | ||
| "go.opencensus.io/trace" | ||
|
|
rauljordan
commented
Mar 11, 2020
shayzluf
previously approved these changes
Mar 11, 2020
rauljordan
changed the title
rauljordan
changed the title
prestonvanloon
previously approved these changes
Mar 11, 2020
0xKiwi
previously approved these changes
Mar 11, 2020
| defer span.End() | ||
|
|
||
| if err := blocks.VerifyProposerSlashing(state, slashing); err != nil { | ||
| numPendingAttesterSlashingFailedSigVerify.Inc() |
prestonvanloon
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No tracking issue.
Description
Write why you are making the changes in this pull request
Currently, our slashing pool does not verify signatures, causing some bad slashings to be attempted to put into blocks, causing issues. Bad slashings are not cleared from pool today.
Write a summary of the changes you are making
This PR ensures we verify the attester/proposer slashing before giving it to a proposer. If it fails for any reason, we clear it from the pool.
Link anything that would be helpful or relevant to the reviewers
This PR fixes old tests and adds regression tests.