Check new state mgmt service is compatible with DB #5231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Ready For Review
Codecov Report
@@ Coverage Diff @@
## master #5231 +/- ##
=======================================
Coverage 46.38% 46.38%
=======================================
Files 231 231
Lines 19147 19147
=======================================
Hits 8881 8881
Misses 8770 8770
Partials 1496 1496 |
0xKiwi
approved these changes
Mar 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check to ensure new state management service is compatible with beacon node DB. It implements the following conditions:
old-state-mgmt-service -> new-state-mgmt-serviceis not ok and errors outnew-state-mgmt-service -> old-state-mgmt-serviceis ok