Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micro optimizations on new-state-mgmt service for initial syncing #5241

Merged
merged 57 commits into from Mar 30, 2020

Conversation

terencechain
Copy link
Member

@terencechain terencechain commented Mar 29, 2020

Built on top of #5215

Micro optimizations on new state mgmt service to optimize initial syncing speed

  • Batch save state summary
  • A node shouldn't wastefully retrieve a finalized state just to get the finalized slot for migration, let's retrieve finalized block instead
  • In the event of playback, instead of using epoch boundary state of slot N, use the last available state of slot N in the DB. It's more efficient

All these minor updates increase initial sync bps for new-state-mgmt by 30-40%

@terencechain terencechain changed the title New state sync micro optimizations Micro optimizations on new-state-mgmt service for initial syncing Mar 30, 2020
@terencechain terencechain self-assigned this Mar 30, 2020
@terencechain terencechain added Ready For Review A pull request ready for code review and removed In Progress labels Mar 30, 2020
@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #5241 into master will decrease coverage by 0.35%.
The diff coverage is 73.72%.

@@            Coverage Diff             @@
##           master    #5241      +/-   ##
==========================================
- Coverage   56.06%   55.71%   -0.36%     
==========================================
  Files         291      291              
  Lines       23306    22866     -440     
==========================================
- Hits        13066    12739     -327     
+ Misses       8428     8348      -80     
+ Partials     1812     1779      -33

@rauljordan rauljordan merged commit 7f7866f into master Mar 30, 2020
@delete-merged-branch delete-merged-branch bot deleted the new-state-init-sync branch March 30, 2020 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants