Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BlockFetcher RPC functions are inefficient #5340

Closed
0xKiwi opened this issue Apr 7, 2020 · 0 comments · Fixed by #5347
Closed

BlockFetcher RPC functions are inefficient #5340

0xKiwi opened this issue Apr 7, 2020 · 0 comments · Fixed by #5347
Assignees
@0xKiwi

Comments

@0xKiwi
Copy link
Contributor

0xKiwi commented Apr 7, 2020 •
edited

After observation from Nishant and I on the RPC functions used when the beacon chain has to make any block queries. We've noticed that there are a few problems possibly related to #5268.

BlockNumberByTimestamp is extremely inefficient, it goes down from the head of the chain and backwards block-by-block until it finds a block timestamp that fits the requested timestamp.

BlockTimeByHeight does not use the cache for blocks at all.

After these improvements are complete, we should see a considerable speedup in interactions with ETH1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xKiwi 0xKiwi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add cache to Eth1 RPC functions 0xKiwi/prysm
1 participant
@0xKiwi