More efficient list indexed attestation endpoint #5441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farazdagi
reviewed
Apr 16, 2020
There was a problem hiding this comment.
Looks like it was already using state gen for state:
https://github.com/prysmaticlabs/prysm/pull/5441/files#diff-c767c9e73a5894791f1a09e7b26fd917R142
What did this PR change?
|
What happens when new state management is not enabled? |
…-indexed-attestations
shayzluf
changed the title
…abs/prysm into fix-list-indexed-attestations
Codecov Report
@@ Coverage Diff @@
## master #5441 +/- ##
=======================================
Coverage 18.88% 18.88%
=======================================
Files 235 235
Lines 20239 20239
=======================================
Hits 3822 3822
Misses 15823 15823
Partials 594 594 |
0xKiwi
reviewed
Apr 19, 2020
|
@0xKiwi fixed test to cover the bug you pointed to |
terencechain
requested changes
Apr 19, 2020
|
thanks @terencechain for the feedback |
terencechain
approved these changes
Apr 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Resolves] #5373
[Resolves] #5486
Description
list indexed attestations endpoint i using beacondb get state function that only returns the lates few epochs states . using the new state-gen will enable to retrieve committees using old states